| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Philip Warner <pjw(at)rhyme(dot)com(dot)au> |
| Cc: | Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>, Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: New warning in pg_dump |
| Date: | 2004-08-24 03:52:32 |
| Message-ID: | 27748.1093319552@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Philip Warner <pjw(at)rhyme(dot)com(dot)au> writes:
> At 01:27 PM 24/08/2004, Tom Lane wrote:
>> I prefer declaring it as unsigned, which means you drop the
>> \377 end instead ...
> ...I've used explicit values (128) since '\200' is -127.
Actually I'd go with "(unsigned char) '\200'". There's a bunch
of different possible viewpoints here of course, but given that
you are trying to mimic a backend flex file that speaks of \200-\377,
I'd opt for something that's clearly traceable to that form.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shinji Teragaito | 2004-08-24 04:13:43 | HP-UX PA-RISC/Itanium 64-bit Patch and HP-UX 11.23 Patch |
| Previous Message | Philip Warner | 2004-08-24 03:44:10 | Re: New warning in pg_dump |