| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> | 
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> | 
| Cc: | pgsql-patches(at)postgresql(dot)org | 
| Subject: | Re: Interval input: usec, msec | 
| Date: | 2007-05-28 14:50:06 | 
| Message-ID: | 27724.1180363806@sss.pgh.pa.us | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-patches | 
Neil Conway <neilc(at)samurai(dot)com> writes:
> Is there any reason to why DecodeInterval() is willing to accept
> multiple specifications for some time units but not others?
I'd argue that it's an oversight.  I don't have a problem with adding up
the values of units that really translate to the same thing (eg,
'1 week 1 day' -> '8 days'), but I think '1 second 2 second' should
be rejected because it's almost certainly user error.
Does your patch allow '1 millisec 2 microsec', which should be allowed
by this argument?  I suspect that to make it work unsurprisingly, we'd
need to allocate a distinct tmask bit to each logically distinct unit.
(Maybe shortage of tmask bits is why the code is like it is?)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Neil Conway | 2007-05-28 17:54:47 | Re: Interval input: usec, msec | 
| Previous Message | Neil Conway | 2007-05-28 04:44:31 | Interval input: usec, msec |