Re: DROP OWNED BY doesn't work

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: pgsql-patches(at)postgreSQL(dot)org
Subject: Re: DROP OWNED BY doesn't work
Date: 2006-08-20 16:05:57
Message-ID: 27722.1156089957@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Ok, this patch implements more or less this idea; except that instead of
> checking the list of implicit dependencies for later objects, we iterate
> twice on the list of objects to delete, and create a list of implicit
> dependencies on all of them the first time, and delete those not on that
> list the second time.

In the light of morning it occurs to me that probably the best code
factoring for this is for dependency.c to export a
performMultipleDeletions() function that takes an objectAddresses list
of targets and does all the dependency-chasing internally. This would
reduce the amount of cruft that has to be exported from dependency.c.

Other than that, the patch looks plausible in a very fast scan.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-08-20 16:09:29 Re: default child of partition master
Previous Message April Lorenzen 2006-08-20 16:02:12 default child of partition master

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2006-08-20 17:37:44 Re: DROP OWNED BY doesn't work
Previous Message Alvaro Herrera 2006-08-20 05:01:04 Re: DROP OWNED BY doesn't work