| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run. |
| Date: | 2017-05-17 16:39:30 |
| Message-ID: | 27644.1495039170@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 5/17/17 10:14, Tom Lane wrote:
>> What I was concerned about was that pgindent will reindent the second
>> line so that it's impossible to tell whether the spacing is correct.
> pgindent moving string continuations to the left is a completely
> terrible behavior anyway and we should look into changing that. Just
> look at the mess it makes out of SELECT queries in pg_dump.c.
I'd be on board with that, perhaps, but does anyone here have enough
insight into bsd_indent to fix that without breaking other stuff?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2017-05-17 16:44:29 | Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run. |
| Previous Message | Tom Lane | 2017-05-17 16:38:23 | Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2017-05-17 16:44:29 | Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run. |
| Previous Message | Tom Lane | 2017-05-17 16:38:23 | Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run. |