From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Mark Dilger <hornschnorter(at)gmail(dot)com> |
Cc: | David Steele <david(at)pgmasters(dot)net>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Use C99 designated initializers for some structs |
Date: | 2018-08-30 21:53:25 |
Message-ID: | 27632.1535666005@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Mark Dilger <hornschnorter(at)gmail(dot)com> writes:
> I tried doing this perhaps a year ago, and there are a few files with arrays
> of structs whose representations get much larger when you change the format
> in this way. For instance, in guc.c:
> ...
> What should the general rule be for initializing arrays of structs such as these?
I'd argue that there is no reason to convert initializers except where
it's a clear notational win. If it isn't, leaving things alone will
be less of a maintenance problem.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2018-08-30 21:57:12 | Re: 10.5 but not 10.4: backend startup during reindex system: could not read block 0 in file "base/16400/..": read only 0 of 8192 bytes |
Previous Message | Tom Lane | 2018-08-30 21:49:04 | Re: pg_verify_checksums and -fno-strict-aliasing |