| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Chernow <ac(at)esilo(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Merlin Moncure <mmoncure(at)gmail(dot)com> |
| Subject: | Re: [PATCHES] libpq events patch (with sgml docs) |
| Date: | 2008-09-17 02:42:06 |
| Message-ID: | 27615.1221619326@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Andrew Chernow <ac(at)esilo(dot)com> writes:
> Missed that one. Good catch :) Update attached.
Looking at this now. Question: why does PQgetResult invoke the
RESULTCREATE event only for non-error results? This seems a rather
odd asymmetry, particularly in view of the fact that a RESULTDESTROY
event will occur for error results. And surely we do not need to
micro-optimize error cases for speed.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Chernow | 2008-09-17 03:00:51 | Re: [PATCHES] libpq events patch (with sgml docs) |
| Previous Message | Greg Smith | 2008-09-17 01:05:26 | Re: Proposal of SE-PostgreSQL patches (for CommitFest:Sep) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Chernow | 2008-09-17 03:00:51 | Re: [PATCHES] libpq events patch (with sgml docs) |
| Previous Message | Tom Lane | 2008-09-16 19:45:18 | Re: [HACKERS] Infrastructure changes for recovery |