| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Gavin Flower <GavinFlower(at)archidevsys(dot)co(dot)nz>, Noah Misch <noah(at)leadboat(dot)com>, neverov(dot)max(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #16939: Plural interval for negative singular |
| Date: | 2021-04-28 03:43:10 |
| Message-ID: | 2761425.1619581390@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
I wrote:
> Hm. We actually document PQprint. While the other two entry points
> in that file aren't documented, they are listed in exports.txt,
> which means somebody *could* be calling them. I think we'd at least
> have to go through a long deprecation period before we could consider
> removing them.
Meanwhile, returning to the point at hand in this thread: AFAICS
from a quick review of the git logs, the last intentional changes
of user-visible behavior in fe-print.c were more than 20 years ago.
Since then it's only seen in-passing bug fixes, such as libpq-wide
fixes of signal handling.
So, to the extent that this code has any use at all it's for
legacy applications. I don't think we should be making random
changes in its behavior for at-best-weak reasons.
In short, I'm now a vote to revert every single bit of 5da9868ed.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Neil Chen | 2021-04-28 05:22:17 | Re: BUG #16982: pg_rewind cannot deal with configuration files (postgresql.conf) located outside data directory |
| Previous Message | Thomas Munro | 2021-04-28 00:59:48 | Re: BUG #16985: ModifyWaitEvent function does not have pgsocket fd and void *user_data arguments |