Re: psql: small patch to correct filename formatting error in '\s FILE' output

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Ian Lawrence Barwick <barwick(at)gmail(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql: small patch to correct filename formatting error in '\s FILE' output
Date: 2013-11-05 22:54:32
Message-ID: 2759.1383692072@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Ian Lawrence Barwick <barwick(at)gmail(dot)com> writes:
> 2013/9/10 Bruce Momjian <bruce(at)momjian(dot)us>:
>> I still see that weird behavior in git head:
>>
>> pgdevel=# \s history.txt
>> Wrote history to file "./history.txt".
>> pgdevel=# \s /tmp/history.txt
>> Wrote history to file ".//tmp/history.txt".
>> pgdevel=# \cd /tmp
>> pgdevel=# \s /tmp/history.txt
>> Wrote history to file "/tmp//tmp/history.txt".
>>
>> Should I revert the suggested patch?

> IIRC the patch was never applied, the reversion candidate is the existing
> commit 0725065b.

I reverted 0725065b. AFAICT there is no interest in making \s produce
a reliable full path name. There was some interest in making \cd tell
you where it'd chdir'd to, but that would be a separate patch.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2013-11-05 23:29:09 Re: [PATCH] configure: allow adding a custom string to PG_VERSION
Previous Message Andres Freund 2013-11-05 22:40:15 Re: Add cassert-only checks against unlocked use of relations