| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org, Wim Lewis <wiml(at)omnigroup(dot)com>, Marko Kreen <markokr(at)gmail(dot)com>, Jeffrey Walton <noloader(at)gmail(dot)com> |
| Subject: | Re: [COMMITTERS] pgsql: libpq: Support TLS versions beyond TLSv1. |
| Date: | 2014-01-25 16:24:19 |
| Message-ID: | 27559.1390667059@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Noah Misch <noah(at)leadboat(dot)com> writes:
> libpq: Support TLS versions beyond TLSv1.
> Per report from Jeffrey Walton, libpq has been accepting only TLSv1
> exactly. Along the lines of the backend code, libpq will now support
> new versions as OpenSSL adds them.
This patch seems fishy. The commit comment claims that it makes libpq
consistent with the backend, but it doesn't: in the backend, we use
SSLv23_method() but then set only the option SSL_OP_NO_SSLv2. With the
patch, libpq now also sets the option SSL_OP_NO_SSLv3, which I assume
means that we just disabled SSL v3 protocol. Did we actually want to
do that? If so, why wasn't this patch advertised as doing that, and
why wasn't the backend also made to reject SSL v3?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2014-01-25 16:46:22 | Re: [COMMITTERS] pgsql: libpq: Support TLS versions beyond TLSv1. |
| Previous Message | Thom Brown | 2014-01-25 15:41:05 | Re: pgsql: Add recovery_target='immediate' option. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-01-25 16:34:11 | Re: extension_control_path |
| Previous Message | Tom Lane | 2014-01-25 16:06:34 | Re: pg_get_viewdefs() indentation considered harmful |