From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: [PATCH] Reduce noise from tsort |
Date: | 2006-04-15 19:18:11 |
Message-ID: | 27552.1145128691@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
I wrote:
> Well, I vote we take it out, which would eliminate these warnings
> instead of just shorten them. On a platform where tsorting a non-shared
> library's contents is actually essential, libpq.a would be useless
> anyway because of the circular internal references. Presumably,
> anyone who's using Postgres on such a platform only cares about the .so
> library. So I don't see any point in including the tsort step.
> (AFAIK we inherited the tsort stuff from Berkeley; it may have been
> useful once upon a time, but that was a long time ago.)
Attached is a proposed patch that removes all trace of lorder and tsort
from our source tree. The one part of it that I'm not too sure about is
the change to the non-ELF build rule in Makefile.*bsd. Anyone have a
non-ELF BSD system sitting around that they can test on?
regards, tom lane
Attachment | Content-Type | Size |
---|---|---|
unknown_filename | text/plain | 4.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2006-04-15 20:20:45 | Re: Proposed doc-patch: Identifying the Current WAL file |
Previous Message | Simon Riggs | 2006-04-15 18:55:16 | Re: Proposed doc-patch: Identifying the Current WAL file |