| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Michael Meskes <meskes(at)postgresql(dot)org> |
| Subject: | Re: define bool in pgtypeslib_extern.h |
| Date: | 2019-11-06 14:54:25 |
| Message-ID: | 27325.1573052065@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> On Mon, Oct 28, 2019 at 11:27 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> A plausible alternative is to do
>>
>> -#define bool char
>> +#define bool unsigned char
>>
>> which is correct on platforms where we don't use <stdbool.h>,
>> and is at least no worse than now on those where we do. In
>> practice, since we know sizeof(_Bool) == 1 on platforms where
>> we use it, this is probably just fine for dtrace's purposes.
> +1 for the second alternative as it will make it similar to c.h.
Yeah, that's the minimum-risk alternative. I'll go make it so.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-11-06 15:06:42 | Re: Removing pg_pltemplate and creating "trustable" extensions |
| Previous Message | Tom Lane | 2019-11-06 14:49:30 | Re: alternative to PG_CATCH |