Re: PATCH: Don't downcase filepath/filename while loading libraries

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: QL Zhuo <zhuo(dot)dev(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Don't downcase filepath/filename while loading libraries
Date: 2017-06-16 04:27:33
Message-ID: 27314.1497587253@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Fri, Jun 16, 2017 at 1:01 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> (2) My inclination would be not to back-patch. This change could break
>> configurations that worked before, and the lack of prior complaints
>> says that not many people are having a problem with it.

> That's fourteen years without complains, still I cannot imagine any
> cases where it would be a problem as people who would have faced this
> problem but not reported it have likely just enforced the FS to handle
> case-insensitivity for paths.

Well, it's not just about case sensitivity. The comment for
SplitDirectoriesString points out that it deals with embedded spaces
differently, and it also applies canonicalize_path(). I'm too tired
to think hard about what that part might mean for compatibility, but
it probably isn't nothing.

Anyway, I agree that this is an appropriate change for HEAD. Just
not convinced that we should shove it into minor releases.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2017-06-16 04:39:39 PATCH: Don't downcase filepath/filename while loading libraries
Previous Message Michael Paquier 2017-06-16 04:18:01 Re: PATCH: Don't downcase filepath/filename while loading libraries