| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add support for coordinating record typmods among parallel worke |
| Date: | 2017-09-15 14:55:17 |
| Message-ID: | 2728.1505487317@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> The attached patch fixes the problem
> by getting rid of the code that accesses shmem in the detach hook.
> With this patch applied installcheck survives on a cluster with
> force_parallel_worker=regress.
In hopes of getting the buildfarm back to green, I went ahead and pushed
a slightly more aggressive form of this --- I took out the worker-specific
detach function altogether. We can resurrect it if we ever have a more
plausible idea of how to do worker recycling, but for now I don't see a
reason to waste bytes on useless and incorrect code.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-09-15 16:14:33 | pgsql: Add LDAP authentication test suite |
| Previous Message | Tom Lane | 2017-09-15 14:52:35 | pgsql: Get rid of shared_record_typmod_registry_worker_detach; it doesn |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2017-09-15 15:00:44 | Re: Renaming PG_GETARG functions (was Re: PG_GETARG_GISTENTRY?) |
| Previous Message | i.kartyshov | 2017-09-15 14:39:45 | Re: WIP: long transactions on hot standby feedback replica / proof of concept |