From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Warnings around booleans |
Date: | 2015-08-21 17:42:53 |
Message-ID: | 27265.1440178973@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Stephen Frost <sfrost(at)snowman(dot)net> writes:
> On Friday, August 21, 2015, Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me>
> wrote:
>> If I'm not mistaken, the roles introduced in this test are never dropped,
>> which will cause the test to fail on consequent runs.
> Ah, I was thinking there was a reason to not leave them around but couldn't
> think of it and liked the idea of testing the pg_dumpall / pg_upgrade code
> paths associated.
> Perhaps the way to address this is to add a bit of code to drop them if
> they exist? That would be reasonably straight-forward to do, I believe.
It is not really acceptable to leave roles hanging around after "make
installcheck"; that would be a security hazard for the installation.
Please drop them.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2015-08-21 17:47:34 | Re: Warnings around booleans |
Previous Message | Alvaro Herrera | 2015-08-21 17:42:23 | Re: TransactionIdGetCommitTsData and its dereferenced pointers |