Re: increase message string buffer size of watch command of psql

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Ioseph Kim <pgsql-kr(at)postgresql(dot)kr>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: increase message string buffer size of watch command of psql
Date: 2016-06-15 02:56:56
Message-ID: 27231.1465959416@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Ioseph Kim <pgsql-kr(at)postgresql(dot)kr> writes:
> 2016 06 15 01:56 Tom Lane () :
>> I take it from the vast silence that nobody particularly cares one way
>> or the other. On reflection I think that this would be a good change
>> to make, so I'll go do so unless I hear complaints soon. regards, tom
>> lane

> I propose to change from asctime() to sql current_timestamp value,
> then users will change date format with set command DateStyle.

That would require an additional SQL query each time through the loop,
which seems like undue expense. It's also not terribly friendly to the
goal of localization, I should think, given the limited number of
datestyle options and the fact that none of them actually change day or
month names to non-English choices. And it would imply changing the
timestamps from psql's timezone to the backend's. While that might have
been a good way to do it in a green field, it's not the way \watch has
worked in the past, and given the lack of complaints I'm disinclined
to change that.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2016-06-15 03:18:12 Re: [BUG] pg_basebackup from disconnected standby fails
Previous Message Ioseph Kim 2016-06-15 00:37:23 Re: increase message string buffer size of watch command of psql