Re: pgsql: Unbreak the build.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org, Robert Haas <rhaas(at)postgresql(dot)org>
Subject: Re: pgsql: Unbreak the build.
Date: 2022-03-23 15:55:37
Message-ID: 2722835.1648050937@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> And windows still fails tests after this commit: https://cirrus-ci.com/task/6424123323711488?logs=test_bin#L22

Yeah. drongo is reporting

# Running: pg_basebackup --no-sync -cfast -D C:\\prog\\bf\\root\\HEAD\\pgsql.build\\src\\bin\\pg_basebackup\\tmp_check\\tmp_test_vv4i/tarbackup -Ft
Assertion failed: 0, file c:\\prog\\bf\\root\\HEAD\\pgsql.build\\src\\bin\\pg_basebackup\\walmethods.c, line 953
not ok 82 - tar format

# Failed test 'tar format'
# at t/010_pg_basebackup.pl line 261.

which is pointing at

/* not reachable */
Assert(false);

so it's not so unreachable after all.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2022-03-23 16:03:35 Re: pgsql: Unbreak the build.
Previous Message Andres Freund 2022-03-23 15:49:48 Re: pgsql: Unbreak the build.

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-03-23 15:56:17 Re: cpluspluscheck vs ICU
Previous Message Dilip Kumar 2022-03-23 15:55:10 Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints