Re: Possible regression: libpq + SSL aborts when user has no home directory

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Christian Kastner <debian(at)kvr(dot)at>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Possible regression: libpq + SSL aborts when user has no home directory
Date: 2011-03-04 14:55:35
Message-ID: 27204.1299250535@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Fri, Mar 4, 2011 at 00:58, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> One small problem is that if the sslmode is "verify-ca" or
>>> "verify-full", failure to find the root cert file is an error,
>>> and that error message normally includes the pathname at which
>>> the cert file was sought. What shall we print if we couldn't
>>> identify the home directory?

> Is there any case when it would actually be realistic that we don't
> find the home directory, but the user can't figure out that's why it
> couldn't find the file? If so, the "could not get home directory" adds
> some more information... We can't exactly expect the end user to know
> that this is the only codepath that can lead to the error message...

Yeah, after sleeping on it I think that it'd be better to have a
specialized error message for this case. It's not significantly
more code, but it would represent another translatable string,
and I had first thought that dodging that would be good. But it's
a sufficiently odd case that making the error message as explicit
as possible is probably the best thing. Will change and commit.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Kevin Grittner 2011-03-04 15:49:58 Re: BUG #5914: locking error in heap_fetch
Previous Message Heikki Linnakangas 2011-03-04 13:52:05 Re: BUG #5914: locking error in heap_fetch