| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Minor BEFORE DELETE trigger fix |
| Date: | 2004-08-07 07:03:23 |
| Message-ID: | 27186.1091862203@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> writes:
> Now, if for all the triggers on the base relation, !trigger->tgenabled is
> true, then newtuple will always be NULL.
Hmm ... seems like the all-triggers-disabled case should act the same as
the no-triggers-at-all case, which this doesn't seem to do. It does
look broken but this doesn't seem like the correct fix.
>> Also, if there is a point, why are we changing only one of the
>> several ExecFOOTriggers functions?
> Because only BEFORE DELETE worries about trigger procedures returning
> NULL, from memory.
Do I have to do more than raise my eyebrow here?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stefan Kaltenbrunner | 2004-08-07 07:56:55 | psql - missing tab-completion support for tablespaces |
| Previous Message | Dennis Bjorklund | 2004-08-07 07:01:37 | Re: UNICODE characters above 0x10000 |