Re: Extensions, this time with a patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
Cc: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extensions, this time with a patch
Date: 2010-10-20 15:21:56
Message-ID: 27158.1287588116@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>> I don't think that "no changes to the makefiles" is a requirement,
>> or even a wish-list item, for this. I think it's perfectly reasonable
>> for the makefile to have to specify the module name; far better that
>> than that we get the name by some "magic" or other.

> It seemed easy to get a reasonable approach requiring very few edits in
> contribs so I favoured that. Now, it's still entirely possible to hand
> adjust. Determining the extension name automatically from DATA_built or
> DATA is only done where EXTENSION has not been provided,

That is simply a horrid idea. Just make it specify EXTENSION.

> and guessing
> the CONTROL file name from the EXTENSION name only occurs when CONTROL
> has not been provided.

Here, on the other hand, I'm wondering why have two variables at all.
Is there any sane use-case for the control file to not be named the same
as the extension? It seems like that would accomplish little except to
sow confusion.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2010-10-20 15:33:25 Re: Extensions, this time with a patch
Previous Message Dimitri Fontaine 2010-10-20 15:14:17 Re: Extensions, this time with a patch