Re: Common function for percent placeholder replacement

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Common function for percent placeholder replacement
Date: 2022-12-14 17:40:03
Message-ID: 2707471.1671039603@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
> On Wed, Dec 14, 2022 at 08:31:02AM +0100, Peter Eisentraut wrote:
>> + return replace_percent_placeholders(base_command, "df", (const char *[]){target_detail, filename});

> This is a "compound literal", which I gather is required by C99.

> But I don't think that's currently being exercised, so I wonder if it's
> going to break some BF members.

It's pretty illegible, whatever it is. Could we maybe expend a
few more keystrokes in favor of readability?

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-12-14 17:42:32 Re: wake up logical workers after ALTER SUBSCRIPTION
Previous Message Andres Freund 2022-12-14 17:35:52 Re: Minimal logical decoding on standbys