Re: Support isEmptyStringInfo

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Subject: Re: Support isEmptyStringInfo
Date: 2022-03-23 14:13:43
Message-ID: 2706195.1648044823@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> I think that the code is perfectly readable as it is and that this
> change makes it less so.

Yeah, after a quick look through this patch I'm unimpressed too.
The new code is strictly longer, and it requires the introduction
of distracting "!" and "&" operators in many places.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-03-23 14:24:13 pgsql: Unbreak the build.
Previous Message Tom Lane 2022-03-23 14:07:06 Re: clean up test_rls_hooks module