| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jelte Fennema <postgres(at)jeltef(dot)nl>, shiy(dot)fnst(at)fujitsu(dot)com, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Jesse Zhang <sbjesse(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: run pgindent on a regular basis / scripted manner |
| Date: | 2023-02-13 12:57:25 |
| Message-ID: | 2701ad84-05c9-6381-1666-b874c3000d54@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-02-12 Su 15:59, Justin Pryzby wrote:
> It seems like if pgindent knows about git, it ought to process only
> tracked files. Then, it wouldn't need to manually exclude generated
> files, and it wouldn't process vpath builds and who-knows-what else it
> finds in CWD.
for vpath builds use an exclude file that excludes the vpath you use.
I don't really want restrict this to tracked files because it would mean
you can't pgindent files before you `git add` them. And we would still
need to do manual exclusion for some files that are tracked, e.g. the
snowball files.
>
> At least --commit doesn't seem to work when run outside of the root
> source dir.
>
Yeah, I'll fix that, thanks for mentioning.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2023-02-13 13:27:37 | Re: run pgindent on a regular basis / scripted manner |
| Previous Message | Jim Jones | 2023-02-13 12:15:57 | Re: [PATCH] Add pretty-printed XML output option |