Re: Cancel problems of query to pg_stat_statements

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Roman Khapov <rkhapov(at)yandex-team(dot)ru>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Cancel problems of query to pg_stat_statements
Date: 2025-04-28 06:16:19
Message-ID: 26A1F7AF-810A-4D60-A6CB-8B749BCCE747@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 24 Apr 2025, at 22:49, Roman Khapov <rkhapov(at)yandex-team(dot)ru> wrote:
>
> Hi!
> Recently we faced a problem in out production psql installation, which was that we had to cancel all requests to the db, including performance monitoring requests, that uses ps_stat_statements. But we could not cancel the request in usual way, and had to kill -9 the pg process of it.

Interesting problem, thanks for raising it!

> We've noticed that the the query execution stuck on PGSS_TEXT_FILE file reading in function qtext_load_file, which doesn't have CHECK_FOR_INTERRUPTS in the read cycle. In addition to our case with large PGSS_TEXT_FILE (and maybe the problems with virtual disk i/o) that can explain uncancellable pg_stat_statements queries.

I'm afraid it might be not so easy to add CHECK_FOR_INTERRUPTS there. Most probably you was holding a LWLockAcquire(pgss->lock, LW_SHARED) somewhere (do you have a backtrace?), which prevent interrupts anyway.

Thanks!

Best regards, Andrey Borodin.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2025-04-28 06:33:52 Re: Fix slot synchronization with two_phase decoding enabled
Previous Message jian he 2025-04-28 04:36:14 Re: using index to speedup add not null constraints to a table