Re: A few warnings on Windows

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: A few warnings on Windows
Date: 2018-05-01 23:39:13
Message-ID: 26880.1525217953@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> Here's a patch that builds warning-free for me. Result:
> https://ci.appveyor.com/project/macdice/postgres/build/1.0.139

LGTM, pushed.

> Unfortunately my scripting for that doesn't actually build the plperl
> stuff yet (need to cannibalise more buildfarm scripts...) so I can't
> confirm that it'll fix the true/false redefinition warnings visible on
> whelk (VC 2013) and dory (2015) but not hamerkop (2005), thrips
> (2010), bowerbird (2012). It seems likely.

We'll soon find out.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Gierth 2018-05-01 23:56:38 Re: lazy detoasting
Previous Message Tom Lane 2018-05-01 23:35:18 pgsql: Clean up warnings from -Wimplicit-fallthrough.