| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Michael Meskes <meskes(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Not *quite* there on ecpg fixes |
| Date: | 2007-10-04 18:22:40 |
| Message-ID: | 26874.1191522160@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> One thing I noticed is this:
> ifneq ($(PORTNAME), win32)
> OBJS += thread.o
> DLL_DEFFILE=libecpgdll.def
> endif
> Why are we defining DLL_DEFFILE for the non-win32 case but not for the
> win32 case?
Comparing to the libpq Makefile, this seems definitely backward ---
presumably the result is that Makefile.shlib overwrites the deffile
with an all-symbols deffile, eliminating the intended limitation on
which symbols are exported.
Will fix.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2007-10-04 18:33:16 | Re: First steps with 8.3 and autovacuum launcher |
| Previous Message | Tom Lane | 2007-10-04 18:12:14 | Re: Not *quite* there on ecpg fixes |