Re: pgbench --progress-timestamp no longer works correctly

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench --progress-timestamp no longer works correctly
Date: 2017-04-11 13:02:51
Message-ID: 26871.1491915771@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jeff Janes <jeff(dot)janes(at)gmail(dot)com> writes:
> --progress-timestamp is supposed to make -P report a Unix Epoch time stamp,
> for easy correlation with the entries in other log files (like the postgres
> server log file using %n).

> But that broke in this commit:

> commit 1d63f7d2d180c8708bc12710254eb7b45823440f
> Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> Date: Mon Jan 2 13:41:51 2017 -0500

> Use clock_gettime(), if available, in instr_time measurements.

Fixed, thanks. I suspect I missed this spot because it randomly used
INSTR_TIME_GET_MILLISEC instead of INSTR_TIME_GET_DOUBLE; but for
whatever reason, I missed it.

(So presumably, this option never worked properly on Windows ... but
it will now.)

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2017-04-11 13:03:11 Re: Some thoughts about SCRAM implementation
Previous Message Ashutosh Bapat 2017-04-11 12:59:44 Re: Partitioned tables and relfilenode