| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com> |
| Cc: | Pgsql-Patches <pgsql-patches(at)postgresql(dot)org>, Pgsql-Cygwin <pgsql-cygwin(at)postgresql(dot)org>, Michael Lemke <lemkemch(at)t-online(dot)de> |
| Subject: | Re: [PATCHES] Cygwin PostgreSQL ESQL Patch |
| Date: | 2001-04-20 16:43:30 |
| Message-ID: | 26867.987785010@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-cygwin pgsql-patches |
Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com> writes:
> --- include/sqlca.h 2001/03/22 06:16:20 1.16
> +++ include/sqlca.h 2001/04/20 14:15:01
> @@ -1,6 +1,12 @@
> #ifndef POSTGRES_SQLCA_H
> #define POSTGRES_SQLCA_H
> +#ifdef __CYGWIN__
> +#define DLLIMPORT __declspec (dllimport)
> +#else
> +#define DLLIMPORT
> +#endif /* __CYGWIN__ */
> +
> #define SQLERRMC_LEN 70
This seems rather bad --- why should sqlca.h define this symbol? What
happens if sqlca.h is included in a file that also includes other
Postgres includes, which will probably pull in c.h where the real
definition is? I'd suggest adding
#include "postgres_ext.h"
#include "c.h"
instead, which may be more namespace pollution than we'd like, but
at least it does not create a potential definition conflict.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jason Tishler | 2001-04-20 18:27:19 | Re: [PATCHES] Cygwin PostgreSQL ESQL Patch |
| Previous Message | Jason Tishler | 2001-04-20 15:58:48 | Re: initdb fails |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jason Tishler | 2001-04-20 18:27:19 | Re: [PATCHES] Cygwin PostgreSQL ESQL Patch |
| Previous Message | Jason Tishler | 2001-04-20 15:36:44 | Cygwin PostgreSQL ESQL Patch |