Re: [PROPOSAL] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind

From: Nikolay Shaplov <n(dot)shaplov(at)postgrespro(dot)ru>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PROPOSAL] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind
Date: 2016-05-25 17:30:39
Message-ID: 2675173.UdFh6OGSxV@nataraj-amd64
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

В письме от 25 мая 2016 13:25:38 Вы написали:
> Teodor Sigaev wrote:
> > >This all should me moved behind "access method" abstraction...
> >
> > +1 relopt_kind should be moved in am, at least. Or removed.
>
> Hm, but we have tablespace options too, so I'm not sure that using AM as
> abstraction level is correct.
We will use am for all indexes, and keep all the rest in relopotion.c for
non-indexes. May be divided options catalog into sections one section for each
kind.

And as I also would like to use this code for dynamic attoptions later, I
would like to remove relopt_kind at all. Because it spoils live in that case.

--
Nikolay Shaplov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marco Nenciarini 2016-05-25 17:33:12 Re: [HACKERS] BUG #13473: VACUUM FREEZE mistakenly cancel standby sessions
Previous Message Alvaro Herrera 2016-05-25 17:25:38 Re: [PROPOSAL] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind