| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Marco Atzeri <marco(dot)atzeri(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: narwhal and PGDLLIMPORT |
| Date: | 2014-02-15 18:17:51 |
| Message-ID: | 26695.1392488271@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2014-02-15 18:21:56 +0100, Andres Freund wrote:
>> On 2014-02-15 12:16:58 -0500, Tom Lane wrote:
>>> Yeah, there are enough copies of that stuff that centralizing them
>>> sounds like a great idea. Call it "pg_getopt.h", perhaps?
> Patch attached. I am not sure whether HAVE_GETOPT is the best condition
> to use, since it's set by configure by a link based check, same goes for
> HAVE_INT_OPTERR. The other choices would be relying on HAVE_GETOPT_H or
> a new AC_CHECK_DECL.
Thanks. I'll look this over and try to get it committed before brolga's
next scheduled run. At least this'll ensure we only have one place to
tweak if more tweaking is needed.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-02-15 19:35:02 | Re: narwhal and PGDLLIMPORT |
| Previous Message | Andres Freund | 2014-02-15 18:08:40 | Re: 9.2.1 & index-only scans : abnormal heap fetches after VACUUM FULL |