From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Jon Jensen <jon(at)endpoint(dot)com>, Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Chris Campbell <chris(at)bignerdranch(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] pg_dump --comment? |
Date: | 2004-06-04 13:43:53 |
Message-ID: | 26695.1086356633@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> What happens in a pg_dump -Fc / pg_restore scenario?
> So, in non-ascii format, I need to dump a comment record and read it
> back on restore? Yuck. Anyone want to tackle that?
Yes. Hacking the output routines alone is almost never the right way
to do things in pg_dump.
My feeling is that if anyone cares to tackle this, it would be
appropriate to add a record type that carries a user-supplied
comment, and then people could do something like
pg_dump --comment "generated on `date`"
if they want to have a timestamp. I don't want a timestamp put
into the file by default, because that creates problems for
comparing dump files.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2004-06-04 13:57:48 | Re: upper() / lower() regression test case needed? |
Previous Message | Andreas Pflug | 2004-06-04 13:36:52 | Re: Compiling libpq with VisualC |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-06-05 04:57:42 | Re: [HACKERS] pg_dump --comment? |
Previous Message | Andreas Pflug | 2004-06-04 13:36:52 | Re: Compiling libpq with VisualC |