Re: pgsql: Raise maximum value of several timeout parameters

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Raise maximum value of several timeout parameters
Date: 2011-03-19 00:43:35
Message-ID: 26643.1300495415@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 03/17/2011 02:25 PM, Peter Eisentraut wrote:
>> Raise maximum value of several timeout parameters

> Did we not intend to backpatch this? The max_standby_*_delay settings
> are particularly worrisome to me, and ISTM there's a good case for
> calling these just bugs. Surely nobody is relying on the maximum value
> being 35 minutes.

I would argue that this isn't a bug fix: the code was operating as
designed. What it is is a feature improvement, and one that has nonzero
risk of introducing new bugs. So I vote for no backpatch. Let it make
its way into the world after a beta cycle.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-03-19 00:52:37 Re: Re: [COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause,
Previous Message Bruce Momjian 2011-03-18 23:18:34 pgsql: Document that the timestamp returned by pg_last_xact_replay_time