Re: hostorder and failover_timeout for libpq

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Ildar Musin <ildar(at)adeven(dot)com>, surafel3000(at)gmail(dot)com, i(dot)musin(at)postgrespro(dot)ru, pgsql-hackers(at)postgresql(dot)org, v(dot)wagner(at)postgrespro(dot)ru
Subject: Re: hostorder and failover_timeout for libpq
Date: 2019-01-14 22:24:56
Message-ID: 26626.1547504696@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Wed, Sep 19, 2018 at 02:26:53PM +0200, Ildar Musin wrote:
>> At this point I'd like to ask community what in your opinion would be the
>> best course of action and whether this feature should be implemented within
>> libpq at all? Because from my POV there are factors that really depend on
>> network architecture and there is probably no single right solution.

> By the way, I can see that the latest patch available does not apply at
> tries to juggle with multiple concepts. I can see at least two of them:
> failover_timeout and hostorder. You should split things. I have moved
> the patch to next CF, waiting on author.

Per the discussion about the nearby prefer-standby patch,

https://www.postgresql.org/message-id/flat/CAF3+xM+8-ztOkaV9gHiJ3wfgENTq97QcjXQt+rbFQ6F7oNzt9A(at)mail(dot)gmail(dot)com

it seems pretty unfortunate that this patch proposes functionality
that's nearly identical to something in pgJDBC, but isn't using the
same terminology pgJDBC uses.

It's even more unfortunate that we have three separate patch proposal
threads that are touching more or less the same territory, but don't
seem to be talking to each other. This one is also relevant:

https://www.postgresql.org/message-id/flat/1700970(dot)cRWpxnom9y(at)hammer(dot)magicstack(dot)net

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-01-14 22:31:07 Re: unique, partitioned index fails to distinguish index key from INCLUDEd columns
Previous Message Tom Lane 2019-01-14 22:17:16 Re: Libpq support to connect to standby server as priority