| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Subject: | Re: Large writable variables |
| Date: | 2018-10-16 20:36:12 |
| Message-ID: | 26620.1539722172@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> Attached is a patch that shrinks fmgr_builtins by 25%. That seems
> worthwhile, it's pretty frequently accessed, making it more dense is
> helpful. Unless somebody protests soon, I'm going to apply that...
Hah. I'm pretty sure that struct *was* set up with an eye to padding ...
on 32-bit machines. This does make it shorter on 64-bit, but also
makes the size not a power of 2, which might add a few cycles to
array indexing calculations. Might be worth checking whether that's
going to be an issue anywhere.
What's the point of the extra const decoration on funcName? ISTM
the whole struct should be const, or not.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gavin Flower | 2018-10-16 20:38:18 | Re: Large writable variables |
| Previous Message | Andres Freund | 2018-10-16 20:11:45 | Re: Large writable variables |