Re: pg_dump throwing "column number -1 is out of range 0..36" on HEAD

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: pg_dump throwing "column number -1 is out of range 0..36" on HEAD
Date: 2019-05-22 13:46:19
Message-ID: 26618.1558532779@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> Trying to do pg_dump[all] on a 9.5 or older server results in spurious
> failures:
> pg_dump: column number -1 is out of range 0..36

> After looking around, the problem comes from
> check_tuple_field_number(), more specifically from getTables() where
> someone has forgotten to add NULL values for amname when querying
> older server versions.

> Attached is a patch to fix that. I am not seeing other failures with
> an instance that includes all the contents of installcheck, so it
> seems that the rest is fine.

Looks like the right fix. I'm sad that the buildfarm did not catch
this ... why wouldn't the cross-version-upgrade tests have seen it?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-05-22 13:56:07 FullTransactionId changes are causing portability issues
Previous Message Tom Lane 2019-05-22 13:32:20 Re: SQL statement PREPARE does not work in ECPG