From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Derek Hans <derek(dot)hans(at)gmail(dot)com> |
Subject: | Re: Update does not move row across foreign partitions in v11 |
Date: | 2019-03-08 00:36:07 |
Message-ID: | 265a9c20-4848-a68a-92ca-9016b22b64cc@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-hackers |
On 2019/03/07 22:54, Robert Haas wrote:
> On Thu, Mar 7, 2019 at 7:35 AM Etsuro Fujita
> <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> Thanks for the patch!
>>
>> The patch looks good to me, but one thing I'm wondering is: as suggested
>> by David, it would be better to rephrase this mention in the UPDATE
>> reference page, in a single commit:
>>
>> "Currently, rows cannot be moved from a partition that is a foreign
>> table to some other partition, but they can be moved into a foreign
>> table if the foreign data wrapper supports it."
>>
>> I don't think it needs to be completely rephrased; it's enough for me to
>> rewrite it to something like this:
>>
>> "Currently, rows cannot be moved from a foreign-table partition to some
>> other partition, but they can be moved into a foreign-table partition if
>> the foreign data wrapper supports tuple routing."
>
> I prefer David's wording.
IIUC, David's suggestion [1] is to change the existing wording, which he
found hard to parse, to something like Fujita-san is suggesting.
Thanks,
Amit
From | Date | Subject | |
---|---|---|---|
Next Message | Julie Nishimura | 2019-03-08 01:53:31 | Re: partial data migration |
Previous Message | Ron | 2019-03-07 22:26:19 | Re: Future Non-server Windows support??? |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2019-03-08 01:00:05 | Re: Tighten error control for OpenTransientFile/CloseTransientFile |
Previous Message | Jerry Jelinek | 2019-03-07 23:35:09 | Re: patch to allow disable of WAL recycling |