From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org, sebastian(dot)patino-lang(at)posteo(dot)net |
Subject: | Re: Rethinking the implementation of ts_headline() |
Date: | 2023-04-06 19:55:58 |
Message-ID: | 2658086.1680810958@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alexander Lakhin <exclusion(at)gmail(dot)com> writes:
> I've found that starting from commit 5a617d75 this query:
> SELECT ts_headline('english', 'To be, or not to be', to_tsquery('english', 'or'));
> invokes a valgrind-detected error:
> ==00:00:00:03.950 3241424== Invalid read of size 1
On my machine, I also see PG-reported errors such as "unrecognized
operator: 0". It's a live bug all right. We need to be more careful
about empty tsqueries.
> But the less-verbose call:
> SELECT ts_headline('', '');
> discovers a different error even on 5a617d75~1:
> ==00:00:00:04.113 3139158== Conditional jump or move depends on uninitialised value(s)
> ==00:00:00:04.113 3139158== at 0x77B44F: mark_fragment (wparser_def.c:2100)
Yeah, this one seems to be ancient sloppiness. I don't think it has
any bad effect beyond annoying valgrind, but I fixed it anyway.
Thanks for the report!
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | tison | 2023-04-06 20:13:51 | Git sources doesn't contain the INSATLL file? |
Previous Message | Melanie Plageman | 2023-04-06 19:09:08 | Re: Should vacuum process config file reload more often |