Re: pgsql: Add configure infrastructure to detect support for C99's restric

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add configure infrastructure to detect support for C99's restric
Date: 2017-10-12 17:55:07
Message-ID: 2656.1507830907@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2017-10-12 11:30:00 -0400, Tom Lane wrote:
>> I don't actually see why you need a #define at all --- "restrict" is the
>> standard spelling of the keyword no?

> It is, but a lot of compilers name it differently, e.g. __restrict in
> the case of msvc.

It's 2017 and they're still not C99 compliant? Oh well.

TBH, I really doubt that restrict buys us enough performance to justify
dealing with this. I'd just revert that change altogether.

Or, if you insist on having it, we're going to have to go the pg_restrict
route. I don't see why that means duplicating any configure logic: on
non-Windows we can use the autoconf probe and then write
"#define pg_restrict restrict".

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2017-10-12 18:03:34 Re: pgsql: Add configure infrastructure to detect support for C99's restric
Previous Message Andres Freund 2017-10-12 17:45:44 Re: pgsql: Add configure infrastructure to detect support for C99's restric

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-10-12 18:03:34 Re: pgsql: Add configure infrastructure to detect support for C99's restric
Previous Message Andres Freund 2017-10-12 17:45:44 Re: pgsql: Add configure infrastructure to detect support for C99's restric