| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Neil Conway <neilc(at)samurai(dot)com>, pgsql-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: ldap: fix resource leak |
| Date: | 2006-11-06 00:28:48 |
| Message-ID: | 26557.1162772928@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
I wrote:
> ... Not sure that
> this is actually a net win though, as a PANIC might well be considered a
> worse problem than a one-time leak of some LDAP state.
Come to think of it: either elog(ERROR) or a failure return from
CheckLDAPAuth is going to lead directly to backend exit, so the
whole thing is pretty much a cosmetic issue anyway. I don't object
to adding the ldap_unbind calls, but I'd not recommend adding a large
pile of code.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Neil Conway | 2006-11-06 01:50:47 | Re: ldap: fix resource leak |
| Previous Message | Tom Lane | 2006-11-06 00:16:14 | Re: ldap: fix resource leak |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Neil Conway | 2006-11-06 01:50:47 | Re: ldap: fix resource leak |
| Previous Message | Tom Lane | 2006-11-06 00:16:14 | Re: ldap: fix resource leak |