| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17847: Unaligned memory access in ltree_gist |
| Date: | 2023-04-18 15:06:41 |
| Message-ID: | 2654443.1681830401@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Alexander Korotkov <aekorotkov(at)gmail(dot)com> writes:
> LGMT. I'm going to push v3 unless there are more comments.
I think this reads pretty awkwardly:
+ERROR: siglen value must be integer-aligned
+DETAIL: Valid are int-aligned values between "4" and "2024".
The DETAIL message's grammar seems a bit off. Also, this is confusing the
range limitation with the alignment requirement. How about just saying
ERROR: siglen value must be a multiple of 4
and leaving out-of-range cases to be handled by the existing check?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Borisov | 2023-04-18 15:19:27 | Re: BUG #17847: Unaligned memory access in ltree_gist |
| Previous Message | Noah Misch | 2023-04-18 14:08:46 | Re: BUG #17901: Unexpected 'permission denied' error depending on which template used to create database |