Re: pgsql: Consistently test for in-use shared memory.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Consistently test for in-use shared memory.
Date: 2019-04-16 00:08:48
Message-ID: 26478.1555373328@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Noah Misch <noah(at)leadboat(dot)com> writes:
> Consistently test for in-use shared memory.

Hmm ... conchuela has just found another problem with this test case:

ok 2 - detected live backend via shared memory
# Running: postgres --single -D /home/pgbf/buildroot/HEAD/pgsql.build/src/test/recovery/tmp_check/t_017_shm_gnat_data/pgdata template1
ack Broken pipe: write( 16, 'SELECT 1 + 1' ) at /usr/local/lib/perl5/site_perl/IPC/Run/IO.pm line 549.

I interpret this as "the single-user backend exited before we could stuff
'SELECT 1 + 1' down the pipe to it, and the Perl script is not expecting
to get a write failure there".

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2019-04-16 00:50:19 Re: pgsql: Consistently test for in-use shared memory.
Previous Message Tom Lane 2019-04-15 23:33:05 pgsql: Use [FLEXIBLE_ARRAY_MEMBER] not [1] in MultiSortSupportData.