| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Andrey Borodin <amborodin86(at)gmail(dot)com>, Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: Experiments with Postgres and SSL |
| Date: | 2024-04-08 01:40:00 |
| Message-ID: | 26465480-4b6c-4296-bd29-c2bc0db65b7c@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08/04/2024 04:28, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>> Committed this. Thank you to everyone involved!
>
> Looks like perlcritic isn't too happy with the test code:
> koel and crake say
>
> ./src/test/libpq_encryption/t/001_negotiate_encryption.pl: Return value of flagged function ignored - chmod at line 138, column 2. See pages 208,278 of PBP. ([InputOutput::RequireCheckedSyscalls] Severity: 5)
> ./src/test/libpq_encryption/t/001_negotiate_encryption.pl: Return value of flagged function ignored - open at line 184, column 1. See pages 208,278 of PBP. ([InputOutput::RequireCheckedSyscalls] Severity: 5)
Fixed, thanks.
I'll make a note in my personal TODO list to add perlcritic to cirrus CI
if possible. I rely heavily on that nowadays to catch issues before the
buildfarm.
--
Heikki Linnakangas
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-04-08 01:41:23 | Re: Coverity complains about simplehash.h's SH_STAT() |
| Previous Message | Peter Geoghegan | 2024-04-08 01:36:17 | Re: Optimizing nbtree ScalarArrayOp execution, allowing multi-column ordered scans, skip scan |