Re: Is necessary to use SEQ_MAXVALUE in pg_dump?

Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
> This construct is used to determine if max_value/min_value is used and
> after that pg_dump add NO MAXVALUE to the output instead of the value.
> If I compare it with manual documentation NO MAXVALUE uses default value
> and I do not see any reason to have this code there. I think we can
> remove this code and release dependency on sequence.h.

IIUC you are proposing that it's okay to print random-huge-values in
the dumped CREATE SEQUENCE commands. I don't agree with that.
In particular it would make for a legacy/compatibility issue for
INT64_IS_BROKEN platforms.

A better solution might be to move the declarations of
SEQ_MINVALUE/SEQ_MAXVALUE someplace else.

regards, tom lane