Re: Wording in TABLESAMPLE documentation

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: paddor(at)gmail(dot)com, pgsql-docs(at)postgresql(dot)org
Subject: Re: Wording in TABLESAMPLE documentation
Date: 2016-08-12 14:24:13
Message-ID: 26367.1471011853@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> On 11 August 2016 at 17:21, <paddor(at)gmail(dot)com> wrote:
>> &gt; If REPEATABLE is not given then a new random sample is selected for each
>> query.
>>
>> the word &quot;sample&quot; should be &quot;seed&quot;. Of course it results in a new random
>> sample as well, but IMHO this sentence is about what happens to the seed in
>> case REPEATABLE (seed) is omitted.

> Corrected, thanks.

I do not think this is an improvement. The sentence was specifically about
whether the sample (that is, the set of rows selected) would change. This
rewording essentially removes that user-visible behavior guarantee, and
for what? It's certainly not any clearer.

regards, tom lane

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Simon Riggs 2016-08-12 14:49:53 Re: Wording in TABLESAMPLE documentation
Previous Message Tom Lane 2016-08-12 14:01:44 Re: Undocumented behavior od DROP SCHEMA ... CASCADE