From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Add absolute value to dict_int |
Date: | 2020-03-10 16:32:38 |
Message-ID: | 26339.1583857958@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I wrote:
> So all we really need to do is upgrade [de]serialize_deflist to be smarter
> about int and float nodes. This is still a bit invasive because somebody
> decided to make deserialize_deflist serve two masters, and I don't feel
> like working through whether the prsheadline code would cope nicely with
> non-string output nodes. So the first patch attached adds a flag argument
> to deserialize_deflist to tell it whether to force all the values to
> strings.
On closer inspection, it doesn't seem that changing the behavior for
prsheadline will make any difference. The only extant code that
reads that result is prsd_headline which always uses defGetString,
and probably any third-party text search parsers would too.
So I've pushed this without the extra flag argument.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Julien Rouhaud | 2020-03-10 16:38:30 | Re: backend type in log_line_prefix? |
Previous Message | David Steele | 2020-03-10 16:15:35 | Re: improve transparency of bitmap-only heap scans |