Re: [HACKERS] Re: include-file cleanup

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Re: include-file cleanup
Date: 1999-07-18 03:25:09
Message-ID: 26320.932268309@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
>> OK, so then no .c files should be including c.h directly anymore?
>> Everything should include either postgres.h, or config.h if it's
>> not tightly tied to the system?

I misread your prior mail --- you have fixed c.h to include
config.h, so it's safe to include c.h directly if not including
postgres.h. The real story now is: either c.h or postgres.h should be
the first file included by all .c files in Postgres, to ensure that the
autoconfigure symbols from config.h are picked up.

Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> writes:
> Some port stuff includes just c.h. Not sure why.

That makes sense to me for files that are just duplicating missing
system functions, and don't really need to be aware that they are
inside Postgres.

Looks like things are in good shape now. I will run a compile here
momentarily...

regards, tom lane

Browse pgsql-hackers by date

  From Date Subject
Next Message Jan Wieck 1999-07-18 09:56:03 Re: [HACKERS] New version number 6.6 or 7.0
Previous Message Bruce Momjian 1999-07-18 02:56:32 Re: [HACKERS] Re: include-file cleanup