Re: [COMMITTERS] pgsql: Sigh ...

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Sigh ...
Date: 2008-05-02 22:28:41
Message-ID: 26232.1209767321@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> ! print O "#define RELSEG_SIZE ",
> ! (1024 / $self->{options}->{blocksize}) *
> ! $self->{options}->{segsize} * 1024, "\n";

This doesn't look quite right; unless the arithmetic is being done in
floating point? I had it like this in configure.in:

RELSEG_SIZE=`expr '(' 1024 '*' ${segsize} / ${blocksize} ')' '*' 1024`

Also it looks like you missed adding segsize to the config.pl comments.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2008-05-02 22:50:21 pgsql: Update documentation for psql relation-size-in-\dt+ patch.
Previous Message Andrew Dunstan 2008-05-02 22:18:29 Re: [COMMITTERS] pgsql: Sigh ...

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2008-05-02 23:05:05 Re: [COMMITTERS] pgsql: Sigh ...
Previous Message Andrew Dunstan 2008-05-02 22:18:29 Re: [COMMITTERS] pgsql: Sigh ...

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2008-05-02 23:05:05 Re: [COMMITTERS] pgsql: Sigh ...
Previous Message Andrew Dunstan 2008-05-02 22:18:29 Re: [COMMITTERS] pgsql: Sigh ...