Re: [HACKERS] [PATCH] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind for custom AM

From: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: [HACKERS] [PATCH] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind for custom AM
Date: 2017-11-28 06:12:01
Message-ID: 2621611.3GR6eXjdAP@x200m
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

В письме от 28 ноября 2017 11:23:38 пользователь Michael Paquier написал:
> On Tue, Nov 28, 2017 at 11:22 AM, Michael Paquier
>
> <michael(dot)paquier(at)gmail(dot)com> wrote:
> > On Tue, Nov 14, 2017 at 4:44 PM, Michael Paquier
> >
> > <michael(dot)paquier(at)gmail(dot)com> wrote:
> >> On Mon, Oct 30, 2017 at 9:49 AM, Nikolay Shaplov <dhyan(at)nataraj(dot)su>
wrote:
> >>> В письме от 3 сентября 2017 11:45:43 пользователь Alvaro Herrera
> >>> написал:
> >>>
> >>> Yet another git rebase. This patch can be applied to master branch
> >>> again.
> >>>
> >>> For this patch no review needed now, as I will offer part of it (one
> >>> that
> >>> refuses to set toast reloptions when there is no TOAST table) as a
> >>> separate
> >>> patch.
> >>
> >> This patch needs a rebase, there are conflicts with HEAD.
> >
> > Bumping the patch to next CF as no updates have happened for the last two
> > weeks.
> Er, returned with feedback.. This will be my last patch for the day.
May be you are right. This patch should be split into smaller patches. I will
do it bit by bit whet I have time. But I see no reason for the big one to
remain on commitfest, as it is not for direct commit.

PS. I will do the rebase soon, this patch overlaps with two recent commits. So
this require very careful rebasing....

--
Do code for fun. Can do it for money (Perl & C/C++ ~10h/week)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Victor Drobny 2017-11-28 06:56:10 Re: [HACKERS] new function for tsquery creartion
Previous Message Fabien COELHO 2017-11-28 05:39:07 Re: [HACKERS] PATCH: pgbench - option to build using ppoll() for larger connection counts