Re: PostgreSQL-13.3 parser.y with positional references by named references

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Domingo Alvarez Duarte <mingodad(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: PostgreSQL-13.3 parser.y with positional references by named references
Date: 2021-07-07 08:28:38
Message-ID: 26189a69-2612-dcca-dcc6-b931f8639ea7@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 04.07.21 17:58, Tom Lane wrote:
> Domingo Alvarez Duarte <mingodad(at)gmail(dot)com> writes:
>> Here https://gist.github.com/mingodad/49291e0e9505522c66fcd3fcea4a939d I
>> posted the postgresql-13.3/src/backend/parser/gram.y with positional
>> references by named references that is supported by bison for some time now.
>
> When is "some time now"?

release 2.5 (2011-05-14)

> I do see the point about it being annoying to update $N references
> when a rule is changed. But this solution has enough downsides that
> I'm not sure it's a net win. Maybe if it were applied selectively,
> to just the longer DDL productions, it'd be worth doing?

I agree that it should be applied selectively.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2021-07-07 08:37:15 Re: "debug_invalidate_system_caches_always" is too long
Previous Message Daniel Gustafsson 2021-07-07 07:13:58 Re: trivial improvement to system_or_bail