| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alexander Law <exclusion(at)gmail(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #6510: A simple prompt is displayed using wrong charset |
| Date: | 2012-10-14 16:10:42 |
| Message-ID: | 26179.1350231042@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-general pgsql-hackers |
Alexander Law <exclusion(at)gmail(dot)com> writes:
> +#ifdef WIN32
> + termin = fopen("CONIN$", "r");
> + termout = fopen("CONOUT$", "w+");
> +#else
> termin = fopen(DEVTTY, "r");
> termout = fopen(DEVTTY, "w");
> +#endif
> if (!termin || !termout
My immediate reaction to this patch is "that's a horrible kluge, why
shouldn't we change the definition of DEVTTY instead?" Is there a
similar issue in other places where we use DEVTTY?
Also, why did you change the termout output mode, is that important
or just randomness?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Kupershmidt | 2012-10-14 16:56:46 | Re: pg_ctl restart issue with relative paths |
| Previous Message | Craig Ringer | 2012-10-14 13:45:44 | Re: Sorry to bother you. Please tell me exactly how the compiler was built ODBC |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Arturo Pie Joa | 2012-10-14 19:49:58 | Using incorrect default-value type |
| Previous Message | Alexander Law | 2012-10-14 06:35:04 | Re: BUG #6510: A simple prompt is displayed using wrong charset |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2012-10-14 16:10:55 | Re: [PATCH] Make pg_basebackup configure and start standby [Review] |
| Previous Message | Fujii Masao | 2012-10-14 16:02:20 | Re: [PATCH] Make pg_basebackup configure and start standby [Review] |