Re: SSL tests fail on OpenSSL v3.2.0

From: Bo Anderson <mail(at)boanderson(dot)me>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Tristan Partin <tristan(at)neon(dot)tech>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SSL tests fail on OpenSSL v3.2.0
Date: 2023-11-28 00:29:41
Message-ID: 26144D95-62C4-465A-82CA-48A0BEA79E82@boanderson.me
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

It was first added in SSLeay 0.8.1 which predates OpenSSL let alone the LibreSSL fork.

It probably doesn’t exist in BoringSSL but neither does a lot of things.

> On 28 Nov 2023, at 00:21, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>> Interesting. I have yet to look at that in details, but
>> BIO_get_app_data() exists down to 0.9.8, which is the oldest version
>> we need to support for stable branches. So that looks like a safe
>> bet.
>
> What about LibreSSL? In general, I'm not too pleased with just assuming
> that BIO_get_app_data exists. If we can do that, we can probably remove
> most of the OpenSSL function probes that configure.ac has today. Even
> if that's a good idea in HEAD, I doubt we want to do it all the way back.
>
> I'd be inclined to form the patch more along the lines of
> s/BIO_get_data/BIO_get_app_data/g, with a configure check for
> BIO_get_app_data and falling back to the existing direct use of
> bio->ptr if it's not there.
>
> regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tristan Partin 2023-11-28 00:48:13 Re: SSL tests fail on OpenSSL v3.2.0
Previous Message Tom Lane 2023-11-28 00:21:03 Re: SSL tests fail on OpenSSL v3.2.0